Wireshark-commits: [Wireshark-commits] master 63a1eb2: MQTT v5 malformed packet fixes.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 01 Nov 2018 22:43:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63a1eb2eeaf8cc882277e67062f05d75d448ff57
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

63a1eb2 by Roger Light (roger@xxxxxxxxxx):

    MQTT v5 malformed packet fixes.
    
    Neither of the following situations were reading MQTT v5 properties from
    the packet, leading to valid MQTT 5 packets being marked as malformed.
    
    CONNECT packet with a Will
    UNSUBSCRIBE packet
    
    Bug: 15257
    Change-Id: Iedb68e7285832fc5692f793b4354a6402ca8ac8d
    Reviewed-on: https://code.wireshark.org/review/30464
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2947e03   Bluetooth: HCI: Add more description about SCO Packet Types
     add  63a1eb2   MQTT v5 malformed packet fixes.


Summary of changes:
 epan/dissectors/packet-mqtt.c | 40 +++++++++++++++++++++++++++-------------
 1 file changed, 27 insertions(+), 13 deletions(-)