Wireshark-commits: [Wireshark-commits] master 1a2aa0e: to_str: Fixed incorrect order of checks in b
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2018 12:47:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a2aa0e901e38d8abcd0368c500f8990f866783b
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1a2aa0e by Martin Boye Petersen (martinboyepetersen@xxxxxxxxx):

    to_str: Fixed incorrect order of checks in bytestring_to_str.
    
    Issue revealed by commit 281dd22da96daa105580bf25f064ddfdc99a719d.
    The commit that revealed the issue allowed bytestring_to_str to be
    called when len was 0 and *ad was NULL causing a dissector bug to be reported.
    
    Change-Id: I01c2c04154e0514dc2702b5c1c43ed5074d0ac11
    Reviewed-on: https://code.wireshark.org/review/30421
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  8f496ad   Update couchbase dissector for new expiration format
     add  1a2aa0e   to_str: Fixed incorrect order of checks in bytestring_to_str.


Summary of changes:
 epan/to_str.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)