Wireshark-commits: [Wireshark-commits] master 52d60ca: checkAPIs.pl: fix false positive in value_st
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Oct 2018 14:28:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52d60cac72e69cdda020b65aa9b9985c7d604fb2
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

52d60ca by Peter Wu (peter@xxxxxxxxxxxxx):

    checkAPIs.pl: fix false positive in value_string.h
    
    check_value_string_arrays accidentally considered a part of
    value_string.h as value_string definition:
    
        Error: epan/value_string.h                : {0, NULL} is required as the last value_string array entry: value_string array_name[]
        #define _VS_ARRAY_TYPE_NAME(array_name) const value_string array_name[]
    
        #define _VS_ENUM_ENTRY( name, value, string) name
    
    Stripping all pre-processor statements (like #define) would be one way
    to solve it, but at least one function checks for the presence of a
    macro, so instead forbid '#' in the regex for variable name.
    
    Change-Id: I4f47b3a42714c5bc526b0ecd8d2fb1ab076d00a2
    Fixes: v2.9.0rc0-1929-g73644b3f76 ("checkAPIs.pl: speed up check_value_string_arrays and remove_if0_code")
    Reviewed-on: https://code.wireshark.org/review/30391
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4a2739e   Qt: fix saving exported objects after sorting columns
     add  52d60ca   checkAPIs.pl: fix false positive in value_string.h


Summary of changes:
 tools/checkAPIs.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)