Wireshark-commits: [Wireshark-commits] master 63ec998: RTPS: Added RTPS reassembly for DATA_FRAGs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Oct 2018 04:11:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63ec9989dcacb8644459affff982e9372c547586
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

63ec998 by Juanjo Martin (juanjo@xxxxxxx):

    RTPS: Added RTPS reassembly for DATA_FRAGs
    
    The RTPS dissector now reassembles and shows the full sample
    when it has been fragmented into several DATA_FRAG submessages.
    
    There is a boolean preference to enable this feature (disabled
    by default due to the potential memory consumption it can cause).
    
    Change-Id: I394c042acdd54953ad6a082b385a5b94c9097cd5
    Bug: 15227
    Reviewed-on: https://code.wireshark.org/review/30297
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d4b6027   test: make 'double' tests rely on icmp instead of ntp.
     add  63ec998   RTPS: Added RTPS reassembly for DATA_FRAGs


Summary of changes:
 epan/dissectors/packet-rtps.c | 143 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 134 insertions(+), 9 deletions(-)