Wireshark-commits: [Wireshark-commits] master-2.6 03d225b: Qt: fix assertion failure when redissect
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Oct 2018 04:44:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03d225bd142c7ea5656ccc594d2e3444b7f5b730
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

03d225b by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix assertion failure when redissecting with a debug build of Qt
    
    Opening the Follow TCP Stream dialog triggers redissection and ended up
    triggering a "first <= rowCount(parent)" assertion failure. Fix the
    first and end arguments to reflect the actual number of displayed rows.
    
    Bug: 15014
    Change-Id: Ic07834948a133bea752e45751ebe8be2da98a35e
    Reviewed-on: https://code.wireshark.org/review/30302
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit c09428bcf2fd27bce8e7a35be35c60e688fcc098)
    Reviewed-on: https://code.wireshark.org/review/30314
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  afbf5fe   More permission fixes.
     add  03d225b   Qt: fix assertion failure when redissecting with a debug build of Qt


Summary of changes:
 ui/qt/models/packet_list_model.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)