Wireshark-commits: [Wireshark-commits] master c09428b: Qt: fix assertion failure when redissecting
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Oct 2018 20:11:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c09428bcf2fd27bce8e7a35be35c60e688fcc098
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c09428b by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix assertion failure when redissecting with a debug build of Qt
    
    Opening the Follow TCP Stream dialog triggers redissection and ended up
    triggering a "first <= rowCount(parent)" assertion failure. Fix the
    first and end arguments to reflect the actual number of displayed rows.
    
    Bug: 15014
    Change-Id: Ic07834948a133bea752e45751ebe8be2da98a35e
    Reviewed-on: https://code.wireshark.org/review/30302
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fa903e2   ldap: reflect the actual asn1 dissector to the C version.
     add  c09428b   Qt: fix assertion failure when redissecting with a debug build of Qt


Summary of changes:
 ui/qt/models/packet_list_model.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)