Wireshark-commits: [Wireshark-commits] master 8652762: Separate signed and unsigned decimal UAT fie
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Oct 2018 21:03:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8652762738f1bc4a4b5bac221463bb77718b6531
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8652762 by Guy Harris (guy@xxxxxxxxxxxx):

    Separate signed and unsigned decimal UAT fields.
    
    Most of them are unsigned; do the appropriate fetching, checking, and
    writing-to-UAT-file for them.  Have separate macros and routines for the
    one signed one, which is the drbid in the LTE MAC dissector.
    
    Use the Wireshark string-to-number routines; they do the appropriate
    bounds checking, and make sure unsigned numbers don't start with a -.
    
    Change-Id: I4f137aa31d631c5b5622b2c320574b8ab3333f31
    Reviewed-on: https://code.wireshark.org/review/30288
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e0401ad   Updated OPC UA 1.0.4 enumeration
     add  8652762   Separate signed and unsigned decimal UAT fields.


Summary of changes:
 epan/dissectors/packet-mac-lte.c  |  2 +-
 epan/dissectors/packet-mac-nr.c   |  4 +--
 epan/dissectors/packet-pdcp-lte.c |  2 +-
 epan/uat.c                        | 58 ++++++++++++++++++++++-----------------
 epan/uat.h                        | 23 ++++++++++++++--
 5 files changed, 57 insertions(+), 32 deletions(-)