Wireshark-commits: [Wireshark-commits] master-2.6 800e4d0: Make uat_fld_chk_num_hex() more like oth
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Oct 2018 05:59:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=800e4d08d3f140a850504a9c188797426448b86a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

800e4d0 by Guy Harris (guy@xxxxxxxxxxxx):

    Make uat_fld_chk_num_hex() more like other uat_fld_chk_num routines.
    
    Allow a space after the number.
    
    Return "Invalid value" for strings that aren't valid numbers and "Value
    too large" for values that don't fit in a 32-bit integer.
    
    Change-Id: Iff616330968bf434fc7daf822a09ffc4f768105b
    Reviewed-on: https://code.wireshark.org/review/30272
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f9d52c8053080713d88513e4cf686cac43637631)
    Reviewed-on: https://code.wireshark.org/review/30273
    

Actions performed:

    from  6a366ae   Use ws_basetostru32(), rather than strtoul(), when parsing uint preferences.
     add  800e4d0   Make uat_fld_chk_num_hex() more like other uat_fld_chk_num routines.


Summary of changes:
 epan/uat.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)