Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 6a366ae: Use ws_basetostru32(), rather than strtoul(), when parsing u

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a366aec0e5731b0e217e1f464661bc359dc8d50
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

6a366ae by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_basetostru32(), rather than strtoul(), when parsing uint preferences.
    
    Also use ws_hextostru32() when parsing color preferences.
    
    This detects additional errors such as negative values.
    
    Addresses part of
    https://ask.wireshark.org/question/5538/preference-range/.
    
    Change-Id: I526a96fcd3c4ad1ee96b3bd682d7c7fa0bfe3434
    Reviewed-on: https://code.wireshark.org/review/30269
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 3fdc40f434626ef7791288d244277ab1a0b06035)
    Reviewed-on: https://code.wireshark.org/review/30271
    

Actions performed:

    from  4e3c7ae   UAT: HEX Values should be allowed the full uint32 range e.g allow 0xffffffff
     add  6a366ae   Use ws_basetostru32(), rather than strtoul(), when parsing uint preferences.


Summary of changes:
 epan/prefs.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)