Wireshark-commits: [Wireshark-commits] master 3fdc40f: Use ws_basetostru32(), rather than strtoul()
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Oct 2018 21:15:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3fdc40f434626ef7791288d244277ab1a0b06035
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3fdc40f by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_basetostru32(), rather than strtoul(), when parsing uint preferences.
    
    Also use ws_hextostru32() when parsing color preferences.
    
    This detects additional errors such as negative values.
    
    Addresses part of
    https://ask.wireshark.org/question/5538/preference-range/.
    
    Change-Id: I526a96fcd3c4ad1ee96b3bd682d7c7fa0bfe3434
    Reviewed-on: https://code.wireshark.org/review/30269
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1fdc0f4   tshark: replace exit with abort in TRY/CATCH.
     add  3fdc40f   Use ws_basetostru32(), rather than strtoul(), when parsing uint preferences.


Summary of changes:
 epan/prefs.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)