Wireshark-commits: [Wireshark-commits] master 9836e22: test: fix text2pcap tests not to overwrite c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Oct 2018 05:14:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9836e228f4fe4142122d0fd4839575c4314b741c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9836e22 by Peter Wu (peter@xxxxxxxxxxxxx):

    test: fix text2pcap tests not to overwrite case_text2pcap_pcap
    
    Fix an unfortunate typo that disabled all of the pcap tests. Patch the
    correct capinfos output with the expected packets/datasize values and
    fix the dns+icmp datasize case to match the original test.sh value.
    
    Change-Id: I25aac4c8040c2000602753269f69f4bdc4a8a59b
    Reviewed-on: https://code.wireshark.org/review/30167
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  11c9896   We don't support VS prior to 2015 in the master branch.
     add  9836e22   test: fix text2pcap tests not to overwrite case_text2pcap_pcap


Summary of changes:
 test/suite_text2pcap.py | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)