Wireshark-commits: [Wireshark-commits] master-2.6 f6c9d25: DCERPC: fix memleak by removing dummy el
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2018 08:49:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6c9d252009e84c1b2d8a1ff72365a8de9fc1346
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

f6c9d25 by Peter Wu (peter@xxxxxxxxxxxxx):

    DCERPC: fix memleak by removing dummy element from ndr_pointer_list
    
    Instead of creating the pointers list early, defer it to the point when
    a new list item is added. This avoids the need for a dummy element.
    
    This happens to fix the memory leak in bug 14735 as well (verified with
    both ASAN and valgrind).
    
    Change-Id: I3b169dfc447bd7465d06c26e0bd9dfd4225b1307
    Bug: 14735
    Reviewed-on: https://code.wireshark.org/review/30115
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit f57cf9e56c90c0c0c724f415eff35821afaaf849)
    Reviewed-on: https://code.wireshark.org/review/30155
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  fbecf1c   DCERPC: simplify pointer list tracking
     add  f6c9d25   DCERPC: fix memleak by removing dummy element from ndr_pointer_list


Summary of changes:
 epan/dissectors/packet-dcerpc.c | 57 +++++++++++++++++++----------------------
 1 file changed, 27 insertions(+), 30 deletions(-)