Wireshark-commits: [Wireshark-commits] master-2.6 71cf784: eap: don't dissect the identity as IMSI
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2018 06:54:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71cf784bfc5435cd7e1531d9ef7dce462274e9ad
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

71cf784 by Dario Lombardo (lomato@xxxxxxxxx):

    eap: don't dissect the identity as IMSI unless that's the case.
    
    The identity in SIM/AKA/AKA' is IMSI (permanent identity) in some cases only.
    Others contain a pseudonym or a fast reauthentication username. Dissect the
    formers as flat usernames.
    
    Bug: 15196
    Change-Id: Ia4491431b6ff557a248271b743c1e37c4e6c0b24
    Reviewed-on: https://code.wireshark.org/review/30129
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30130
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  3e6de6d   Clean up MSVC version string generation.
     add  71cf784   eap: don't dissect the identity as IMSI unless that's the case.


Summary of changes:
 epan/dissectors/packet-eap.c | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)