Wireshark-commits: [Wireshark-commits] master e1fc60d: Qt: Add back pathLabel in some dialogs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 04:46:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1fc60ddaecaa914e384ae8bc9bf46cca0096df2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e1fc60d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Add back pathLabel in some dialogs
    
    Add the pathLabel for Coloring Rules, Decode As, Display Filters
    and Capture Filter. Put the absolute file path into the pathLabel
    if the file exists. This aligns with UAT dialogs and frames.
    
    Change-Id: I72bd06e31bab220de0a0ef8df99df9a4daed667c
    Reviewed-on: https://code.wireshark.org/review/30089
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eade1c5   Qt: Use regular size buttons on macOS
     add  e1fc60d   Qt: Add back pathLabel in some dialogs


Summary of changes:
 epan/color_filters.c            |  6 +++---
 epan/color_filters.h            |  2 ++
 ui/filter_files.c               | 15 ---------------
 ui/filter_files.h               | 15 +++++++++++++++
 ui/qt/coloring_rules_dialog.cpp | 20 +++++++++++++++++++-
 ui/qt/coloring_rules_dialog.ui  | 26 +++++++++++++++++++++++++-
 ui/qt/decode_as_dialog.cpp      | 19 +++++++++++++++++++
 ui/qt/decode_as_dialog.ui       | 21 ++++++++++++++++++++-
 ui/qt/filter_dialog.cpp         | 20 ++++++++++++++++++++
 ui/qt/filter_dialog.ui          | 21 ++++++++++++++++++++-
 10 files changed, 143 insertions(+), 22 deletions(-)