Wireshark-commits: [Wireshark-commits] master-2.6 73fd53f: Fix Windows dumpcap -i TCP@
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 09 Oct 2018 19:46:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73fd53f0687eeb52dbe675071f470369fd96c8c8
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

73fd53f by James Ko (jck@xxxxxxxxxx):

    Fix Windows dumpcap -i TCP@
    
    Reading from a TCP socket in Windows must not change read state
    variables to values required by cap_thread_read on pipes.
    
    Bug: 15149
    Change-Id: I1efa9288b5954dc4a18b2c68772c54a098a224e7
    Reviewed-on: https://code.wireshark.org/review/29894
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 354c0d4e5f9e988e2f62ee7818456af0bac90cbf)
    Reviewed-on: https://code.wireshark.org/review/30087
    

Actions performed:

    from  6f2c61c   Get rid of duplicate declaration.
     add  73fd53f   Fix Windows dumpcap -i TCP@


Summary of changes:
 dumpcap.c | 81 ++++++++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 51 insertions(+), 30 deletions(-)