Wireshark-commits: [Wireshark-commits] master-2.6 cb45d1f: Make sure we avoid the local code page f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 08 Oct 2018 18:32:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb45d1fcb6e14565124f7b4fb9310a3792dbbcf1
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

cb45d1f by Guy Harris (guy@xxxxxxxxxxxx):

    Make sure we avoid the local code page for command-line arguments.
    
    Do in WinMain() as we do in the Qt main() - fetch the command line with
    GetCommandLineW(), convert it to an argument count and array of UTF-16
    strings with CommandLineToArgvW(), and then convert them to an array of
    UTF-8 strings with arg_list_utf_16to8().
    
    Change-Id: I04bd4182b1ff62573eb132531f4c7f2360f376cc
    Reviewed-on: https://code.wireshark.org/review/30067
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9828b3c   No need to check for dladdr in autotools, either, as we're no longer using it.
     add  cb45d1f   Make sure we avoid the local code page for command-line arguments.


Summary of changes:
 ui/gtk/main.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)