Wireshark-commits: [Wireshark-commits] master f710f21: T125: Add a heuristic test case.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 06 Oct 2018 05:59:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f710f21833e45ed34f23dc9eb66dd6e3e09ead5e
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f710f21 by Émilio Gonzalez (egg997@xxxxxxxxx):

    T125: Add a heuristic test case.
    
      Looks for common T.125 packet types such as erectDomainRequest and
      attachUserRequest. This correctly links COTP with T.125/MCS in case of
      RDP traffic, which results in RDP traffic actually being dissected by
      the RDP dissector.
    
    Change-Id: I14eecc417cf5038779d78207ac0ccf2dd22a1219
    Reviewed-on: https://code.wireshark.org/review/29960
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  5c87810   NGAP: prettify dissection
     add  f710f21   T125: Add a heuristic test case.


Summary of changes:
 epan/dissectors/asn1/t125/packet-t125-template.c | 37 ++++++++++++++++++
 epan/dissectors/packet-t125.c                    | 48 +++++++++++++++++++++---
 2 files changed, 80 insertions(+), 5 deletions(-)