Wireshark-commits: [Wireshark-commits] master-2.6 384e06d: TLS: fix reassembly regression when exte
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Oct 2018 09:09:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=384e06de65c44a033317361e1efad53a7b7af774
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

384e06d by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: fix reassembly regression when extending a PDU
    
    The fragment identifier was changed, but fragment_set_partial_reassembly
    was left unchanged which broke reassembly/decryption when a subdissector
    finishes reassembly, but then requests further reassembly (like HTTP
    with chunked encoding). This bug results in a faulty "Reassembly error,
    protocol TLS: New fragment past old data limits" message.
    
    Bug: 15158
    Change-Id: I636ef623dd65c3feb58da29adf7125d8458f038f
    Fixes: v2.9.0rc0-2003-gbe16d87c60 ("TLS: fix broken reassembly with multiple PDUs in the same frame")
    Reviewed-on: https://code.wireshark.org/review/29967
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 2263ce4f63f91f58d840c628dccaec6a72a0d6fc)
    Reviewed-on: https://code.wireshark.org/review/29970
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  2b349e3   Fix handling of some ISDN calls.
     add  384e06d   TLS: fix reassembly regression when extending a PDU


Summary of changes:
 epan/dissectors/packet-ssl.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)