Wireshark-commits: [Wireshark-commits] master-2.4 353572d: Qt: Show "unknown colorfilters" warning
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Sep 2018 18:22:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=353572d66d9cf0be7cedf70ed83d968ca9abc009
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

353572d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Show "unknown colorfilters" warning when opening the dialog
    
    Show the warning about unknown colorfilters being disabled when
    opening the "Coloring Rules..." dialog to make the user aware of
    this before starting editing the rules.
    
    The user may have corrected the filter and enabled it while having
    the dialog open, and then this warning would be misleading.
    
    Change-Id: Ic7f10495e5561bc2fea413c89cf9ebd187c8f113
    Reviewed-on: https://code.wireshark.org/review/29909
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 45be9668223f3b42b45a6e30d67cb2eee94d2c5b)
    Reviewed-on: https://code.wireshark.org/review/29927
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  c22faac   prefs: Don't remove unknown coloring rules.
     add  353572d   Qt: Show "unknown colorfilters" warning when opening the dialog


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)