Wireshark-commits: [Wireshark-commits] master-2.4 2a989d3: prefs: Reset prefs.unknown_colorfilters
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Sep 2018 17:29:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a989d387f8da8a70b071a4cb9f9bf3bb99f17d7
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

2a989d3 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    prefs: Reset prefs.unknown_colorfilters before reading colorfilters
    
    Reset prefs.unknown_colorfilters in the beginning of read_filters_file()
    to avoid a situation when the preference is set and never cleared.
    This will end up with an error message in UI even when not having
    unknown color filters.
    
    Change-Id: I835dbc2a57f0be6889eb5bce250987dabd796e30
    Reviewed-on: https://code.wireshark.org/review/29904
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit e804e63d4dc7fcf7893d32cd0c420f1736840aeb)
    Reviewed-on: https://code.wireshark.org/review/29925
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  b7575fc   TLS: fix broken reassembly with multiple PDUs in the same frame
     add  2a989d3   prefs: Reset prefs.unknown_colorfilters before reading colorfilters


Summary of changes:
 epan/color_filters.c | 2 ++
 1 file changed, 2 insertions(+)