Wireshark-commits: [Wireshark-commits] master a699fbd: Add a mechanism to register aliases for pref
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Sep 2018 03:24:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a699fbdf45481113470cbc56f89e03cdae730f44
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a699fbd by Guy Harris (guy@xxxxxxxxxxxx):

    Add a mechanism to register aliases for preference modules.
    
    That way, we don't need a chunk of code in epan/prefs.c that knows about
    various preference module mappings; individual dissectors can register
    aliases as appropriate.
    
    (The Nortel Discovery Protocol never *had* any preferences, even when
    it was the SynOptics Network Management Protocol, so there's no need for
    it to register an alias.)
    
    Change-Id: I4a718dac6bb06801cc06a6ee5a28d7ed81e67e5d
    Reviewed-on: https://code.wireshark.org/review/29914
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  cc3d23f   Clean up indentation.
     add  a699fbd   Add a mechanism to register aliases for preference modules.


Summary of changes:
 epan/dissectors/asn1/p1/packet-p1-template.c |   2 +
 epan/dissectors/packet-beep.c                |   2 +
 epan/dissectors/packet-dccp.c                |   2 +
 epan/dissectors/packet-diameter.c            |   2 +
 epan/dissectors/packet-gsm_sms_ud.c          |   2 +
 epan/dissectors/packet-gtp.c                 |   3 +
 epan/dissectors/packet-nsip.c                |   2 +
 epan/dissectors/packet-x25.c                 |   2 +
 epan/prefs.c                                 | 124 +++++++++++++++++++++------
 epan/prefs.h                                 |   5 ++
 10 files changed, 119 insertions(+), 27 deletions(-)