Wireshark-commits: [Wireshark-commits] master db8eddd: DNS: fix DNS transaction tracking for DoH
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Sep 2018 17:51:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db8eddd6cf4e31e6d0c42bd9b7c7ac39d4d472d6
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

db8eddd by Peter Wu (peter@xxxxxxxxxxxxx):

    DNS: fix DNS transaction tracking for DoH
    
    Handle DoH messages specially, use the HTTP/2 Stream ID for matching
    requests with responses. Fixes misleading "retransmission" expert infos
    and properly link (successive) requests with (out-of-order) responses.
    
    Change the "Protocol" column to "DoH" while at it.
    
    Change-Id: I42b22c5c8560ee029051dcb3561e188572a4245f
    Ping-Bug: 14433
    Reviewed-on: https://code.wireshark.org/review/29889
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  46254ca   MAC-NR: Fix up some small issues while viewing SDUs, some of which are dissected as RLC PDUs
     add  db8eddd   DNS: fix DNS transaction tracking for DoH


Summary of changes:
 epan/dissectors/packet-dns.c | 59 ++++++++++++++++++++++++++++++++++----------
 1 file changed, 46 insertions(+), 13 deletions(-)