Wireshark-commits: [Wireshark-commits] master bfd3d76: TLS: split key log contents processing from
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Sep 2018 13:18:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfd3d7685a2e82efc8eb0364eab94b73456c97b0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bfd3d76 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: split key log contents processing from file reading
    
    In case the TLS key log file is provided by means other than a file,
    split the file reading part from the contents processing part. Adjust
    the line handling logic to allow immutable strings. Stick to fgets to
    avoid partial lines in case the read buffer is full.
    
    Rename some SSL -> TLS while at it.
    
    Change-Id: I28da96834833e6096074ce122a6ebc3484655d9f
    Reviewed-on: https://code.wireshark.org/review/29890
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cc69e09   HTTP2: allow subdissectors to query the Stream ID
     add  bfd3d76   TLS: split key log contents processing from file reading


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 123 ++++++++++++++++++++-----------------
 epan/dissectors/packet-tls-utils.h |   4 ++
 2 files changed, 72 insertions(+), 55 deletions(-)