Wireshark-commits: [Wireshark-commits] master d29fa61: HTTP: fix incomplete conversion from SSL to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Sep 2018 20:37:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d29fa61eb32bf14be135eab5ac89b476ffc5235a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d29fa61 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: fix incomplete conversion from SSL to TLS
    
    The frame.protocols list does not contain "ssl" and thus the expert info
    "Unencrypted HTTP protocol detected over encrypted port, could indicate
    a dangerous misconfiguration" was shown even for the normal HTTPS port.
    
    This also renames the http.ssl_port to http.tls_port with no backwards
    compatibility, hopefully that is reasonable.
    
    Change-Id: I5c8481693ff63dc0a19b4dc1de431680bdda3244
    Reviewed-on: https://code.wireshark.org/review/29828
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  aa6d5ee   Use the time stamps in the packet_info structure, not the frame_data structure.
     add  d29fa61   HTTP: fix incomplete conversion from SSL to TLS


Summary of changes:
 epan/dissectors/packet-http.c | 45 +++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 23 deletions(-)