Wireshark-commits: [Wireshark-commits] master ad335a5: Get rid of unnecessary check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Sep 2018 19:58:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad335a52d8af46dda02f9ccd66412a645a06bc00
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ad335a5 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of unnecessary check.
    
    Either pcap_process_pseudo_header() returns -1, in which case we fail,
    or it returns the exact same value as pcap_get_phdr_size().  If we don't
    fail, don't bother to check whether the values are the same.
    
    Change-Id: I18191cc3de2a1c2144ca9b508ed17b2f593fc835
    Reviewed-on: https://code.wireshark.org/review/29879
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c7f4bad   Sort the pseudo-header routines in the order of the switch statements.
     add  ad335a5   Get rid of unnecessary check.


Summary of changes:
 wiretap/pcapng.c | 8 --------
 1 file changed, 8 deletions(-)