Wireshark-commits: [Wireshark-commits] master-2.4 4b78f64: PCP: Add padding for option
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Sep 2018 07:57:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b78f648e51409207ccdb8dcb4dea9b4409ac788
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

4b78f64 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    PCP: Add padding for option
    
    RFC 6887 states that options have to be padded to a multiple
    of 4 octets. This commit adds missing padding.
    
    Bug: 14950
    Change-Id: I68a0631ecdd2f30e24e83b1a6e8dfc55856c9c94
    Reviewed-on: https://code.wireshark.org/review/29832
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1768252ef2c0aa7b7b0e728e752bb8422db2d323)
    Reviewed-on: https://code.wireshark.org/review/29846
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c1ae92b   Handle the NFC LLCP pseudo-header when writing.
     add  4b78f64   PCP: Add padding for option


Summary of changes:
 epan/dissectors/packet-nat-pmp.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)