Wireshark-commits: [Wireshark-commits] master 1302cdb: Sort cases in pcap_write_phdr() - and add mi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Sep 2018 03:02:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1302cdb27c61d9bb369b792287144a50665f9073
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1302cdb by Guy Harris (guy@xxxxxxxxxxxx):

    Sort cases in pcap_write_phdr() - and add missing NFC LLCP case.
    
    Put the cases in pcap_write_phdr() into the same order as the cases in
    pcap_process_pseudo_header().
    
    Doing so revealed that there wasn't a case for WTAP_ENCAP_NFC_LLCP in
    pcap_write_phdr(), so NFC LLCP captures wouldn't be saved correctly.
    Add pcap_write_llcp_pseudoheader() and use it.
    
    Change-Id: I2728a96e63d2e0606ae0bb480f97fe124ab48d17
    Reviewed-on: https://code.wireshark.org/review/29841
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3ddc3b0   Put the code for writing pseudo-headers into individual routines.
     add  1302cdb   Sort cases in pcap_write_phdr() - and add missing NFC LLCP case.


Summary of changes:
 wiretap/pcap-common.c | 50 +++++++++++++++++++++++++++++++++++---------------
 1 file changed, 35 insertions(+), 15 deletions(-)