Wireshark · Wireshark-commits: [Wireshark-commits] master 933de9f: sharkd: cleanup printf() usage during JSON generation (part IV).

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=933de9fdbfde742ebc32c3b70b14e007eec84df4
Submitter: "Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

933de9f by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    sharkd: cleanup printf() usage during JSON generation (part IV).
    
    Many printf()s generates only key, value is generated by
    json_puts_string() or json_print_base64().
    
    Add helper functions sharkd_json_value_string, sharkd_json_value_base64
    to generate key with a string, or base64 as a value.
    
    It lower number of printf() from 156 to 105 (32% reduction).
    
    Change-Id: I22901d9759534a4fab7bcdefd66242fd6c5b20cc
    Reviewed-on: https://code.wireshark.org/review/29821
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    

Actions performed:

    from  70e340a   Qt: Create directories if they should be opened
     add  933de9f   sharkd: cleanup printf() usage during JSON generation (part IV).


Summary of changes:
 sharkd_session.c | 209 ++++++++++++++++++++-----------------------------------
 1 file changed, 76 insertions(+), 133 deletions(-)