Wireshark-commits: [Wireshark-commits] master 5507d1b: sharkd: cleanup printf() usage during JSON g
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Sep 2018 08:39:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5507d1b34477190f1ee6426111580d3f0dcd922a
Submitter: "Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5507d1b by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    sharkd: cleanup printf() usage during JSON generation (part III).
    
    Most of sharkd printf()'s are used to output formatted value with given key.
    Add two formatting-function helpers: sharkd_json_value_anyf and sharkd_json_value_stringf.
    
    Conversion printf to these function lower number of printf() from 300 to 156 (48% reduction).
    
    Change-Id: Ied538cc5b84d48d942e2140ff6b93969579d6132
    Reviewed-on: https://code.wireshark.org/review/29816
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    

Actions performed:

    from  19b8329   Update URL.
     add  5507d1b   sharkd: cleanup printf() usage during JSON generation (part III).


Summary of changes:
 sharkd_session.c | 324 +++++++++++++++++++++++++++++--------------------------
 1 file changed, 173 insertions(+), 151 deletions(-)