Wireshark-commits: [Wireshark-commits] master bf0ceaf: checkhf.pl: speed up find_remove_ei_defs and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Sep 2018 17:54:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf0ceafaf964667c42a9471a104bd62f0f7069f2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bf0ceaf by Peter Wu (peter@xxxxxxxxxxxxx):

    checkhf.pl: speed up find_remove_ei_defs and remove_if0_code
    
    Remove leading spaces early such that the regex in find_remove_ei_defs
    can avoid (falsely) matching every line (saves 97% for packet-rrc.c).
    Copy the improved remove_if0_code from checkAPIs.pl (saves 600ms).
    
    packet-ieee80211.c used to spend 240ms and now completes in 165ms.
    packet-rrc.c used to spend 53.7s and now completes in 0.85s.
    
    Change-Id: I6469f7c11839fab2f33c49d3c839473f1d4902d2
    Reviewed-on: https://code.wireshark.org/review/29795
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b63fe7d   Update the X11 dissector to use the latest mesa and xcbproto.
     add  bf0ceaf   checkhf.pl: speed up find_remove_ei_defs and remove_if0_code


Summary of changes:
 tools/checkhf.pl | 127 ++++++++++++++++++++++++-------------------------------
 1 file changed, 55 insertions(+), 72 deletions(-)