Wireshark-commits: [Wireshark-commits] master-2.6 3341937: ProfiNet: Fix order in AssetManagment
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Sep 2018 13:19:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=334193717baaf5f129bdfaefa782380d2c581336
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

3341937 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    ProfiNet: Fix order in AssetManagment
    
    According to the current Profinet specification in regard
    to the coding of the AM_DeviceIdentification field, the
    dissection order of DeviceId and VendorId is in the wrong
    order.
    
    Bug: 15140
    Change-Id: I9954619a938db382967104de91e2b905677cc171
    Reviewed-on: https://code.wireshark.org/review/29780
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 59c0a962f6aa414b6342a17e831d639d26ac9a85)
    Reviewed-on: https://code.wireshark.org/review/29781
    

Actions performed:

    from  f5f3fdd   Get rid of unused variable, update a comment.
     add  3341937   ProfiNet: Fix order in AssetManagment


Summary of changes:
 plugins/epan/profinet/packet-dcerpc-pn-io.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)