Wireshark-commits: [Wireshark-commits] master 8f08a4e: Try to discourage the use of APIs via counti
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Sep 2018 16:07:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f08a4e74ea8aa56284e6035017adf1c423c4f09
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8f08a4e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Try to discourage the use of APIs via counting.
    
    Add the ability to specify maximum function counts for each group to
    checkAPIs. Add maximum counts for the "termoutput" and "abort" groups
    where needed. Show summaries in various checkAPI targets.
    
    Switch uses of ws_g_warning back to plain g_warning.
    
    Change-Id: I5cbddc8c671729e424eed8551f69116d16491976
    Reviewed-on: https://code.wireshark.org/review/29721
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  ca83042   XRA: Display length information in XRA protocol description. Set correct length of XRA header.
     add  8f08a4e   Try to discourage the use of APIs via counting.


Summary of changes:
 epan/CMakeLists.txt                              |  2 +-
 epan/color_filters.c                             |  3 +-
 epan/disabled_protos.c                           |  9 ++-
 epan/dissectors/CMakeLists.txt                   |  4 +-
 epan/dissectors/asn1/nbap/packet-nbap-template.c |  4 +-
 epan/dissectors/packet-btmesh.c                  |  9 ++-
 epan/dissectors/packet-dcerpc-nt.c               |  3 +-
 epan/dissectors/packet-f5ethtrailer.c            |  7 +-
 epan/dissectors/packet-nbap.c                    |  4 +-
 epan/dissectors/packet-wireguard.c               |  5 +-
 epan/epan.c                                      |  3 +-
 epan/packet.c                                    |  4 +-
 epan/prefs.c                                     | 29 ++++----
 epan/proto.c                                     |  6 +-
 epan/show_exception.c                            |  3 +-
 epan/tap.c                                       |  5 +-
 epan/tvbparse.c                                  | 91 ++++++++++++------------
 epan/value_string.c                              |  5 +-
 epan/wmem/CMakeLists.txt                         |  3 +-
 epan/wmem/wmem_core.c                            |  4 +-
 epan/wslua/CMakeLists.txt                        |  2 +-
 epan/wslua/wslua_file.c                          |  9 ++-
 epan/wslua/wslua_file_handler.c                  | 35 +++++----
 epan/wslua/wslua_frame_info.c                    |  5 +-
 epan/wslua/wslua_gui.c                           | 17 +++--
 epan/wslua/wslua_listener.c                      | 11 ++-
 epan/wslua/wslua_util.c                          |  5 +-
 plugins/epan/mate/CMakeLists.txt                 |  4 +-
 plugins/epan/mate/mate_util.c                    |  5 +-
 plugins/epan/mate/packet-mate.c                  |  1 -
 plugins/epan/transum/packet-transum.c            |  2 +-
 tools/checkAPIs.pl                               | 52 +++++++++++---
 wiretap/CMakeLists.txt                           |  6 +-
 wiretap/pcapng.c                                 |  4 +-
 wsutil/CMakeLists.txt                            |  2 +-
 wsutil/time_util.c                               |  3 +-
 wsutil/ws_printf.h                               |  5 --
 37 files changed, 190 insertions(+), 181 deletions(-)