Wireshark-commits: [Wireshark-commits] master 59ac823: QUIC: refactor packet protection cipher init
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Sep 2018 20:23:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59ac823c3f0490ac689e847d3922ed38ae137ddb
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

59ac823 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: refactor packet protection cipher initialization
    
    The old key update mechanism was never tested and was probably broken
    (using "pp_state->cipher[1 - key_phase]" does not seem correct). To
    prepare for the handshake cipher (draft -13), refactor it a bit and
    remove the PKN parameter.
    
    Change-Id: I481cc00e2e1d44024a709f8b4115ffe5924988e7
    Ping-Bug: 13881
    Reviewed-on: https://code.wireshark.org/review/29676
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  866ff1e   QUIC: use single field for all long header payloads
     add  59ac823   QUIC: refactor packet protection cipher initialization


Summary of changes:
 epan/dissectors/packet-quic.c | 194 ++++++++++++++++++++++--------------------
 1 file changed, 100 insertions(+), 94 deletions(-)