Wireshark-commits: [Wireshark-commits] master 011224b: QUIC: split per-packet state to fix packet c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Sep 2018 10:28:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=011224bff549d57ad5b0b45d67ebf45bdda11e57
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

011224b by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: split per-packet state to fix packet coalescing
    
    Packet coalescing requires separate state for every QUIC packet. Split
    the state as each UDP datagram can contain multiple QUIC packets.
    
    Most datagrams will have only one packet, so to avoid multiple
    allocations, just embed the first packet into the datagram info and use
    a linked list for simplicity.
    
    Change-Id: Ib921e68a7312c6eccb5601b8951ff64cc9ea49cd
    Ping-Bug: 13881
    Reviewed-on: https://code.wireshark.org/review/29647
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  28a7a79   opcua: prevent opcua dissector crash by limiting nesting depth
     add  011224b   QUIC: split per-packet state to fix packet coalescing


Summary of changes:
 epan/dissectors/packet-quic.c | 89 ++++++++++++++++++++++++++-----------------
 1 file changed, 54 insertions(+), 35 deletions(-)