Wireshark · Wireshark-commits: [Wireshark-commits] master a6c3049: sizeof isn't useful when calculating the size of data in the pac

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6c30496df05c6ce3c629dc72c83702d1854f31d
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a6c3049 by Guy Harris (guy@xxxxxxxxxxxx):

    sizeof isn't useful when calculating the size of data in the packet.
    
    Srsly, you're dealing with *one-byte*, *two_byte*, and *four-byte*
    values, might as well say "1", "2", and "4" - either sizeof(guint8) is
    guaranteed to be 1, sizeof(guint16) is guaranteed to be 2, and
    sizeof(guint32) is guaranteed to be 4, in which case you might as well
    just use 1, 2, and 4, or they're *not* guaranteed to be 1, 2, and 44, in
    which case you *have* to use 1, 2, and 4, because a value other than 1,
    2, or 4 is invalid.
    
    Change-Id: I49b354cd619f6fe8d625af0322f4861ad8f9b1f1
    Reviewed-on: https://code.wireshark.org/review/29591
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0d123e5   CMake: Remove some redundant and overly verbose code
     add  a6c3049   sizeof isn't useful when calculating the size of data in the packet.


Summary of changes:
 epan/dissectors/packet-tibia.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)