Wireshark-commits: [Wireshark-commits] master 33e5f0e: sizeof isn't useful when calculating the siz
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Sep 2018 03:43:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33e5f0eba223feab8f23d519f2d36bc544934584
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

33e5f0e by Guy Harris (guy@xxxxxxxxxxxx):

    sizeof isn't useful when calculating the size of data in the packet.
    
    Srsly, you're dealing with *four-byte* value, might as well say "4" -
    either sizeof(guint32) is guaranteed to be 4, in which case you might as
    well just use 4, or it's *not* guaranteed to be 4, in which case you
    *have* to use 4, because a value other than 4 is invalid.
    
    Change-Id: I6deb106f326e9402744a2e728468b3ce4c220b02
    Reviewed-on: https://code.wireshark.org/review/29586
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5bd04a3   sizeof isn't useful when adding to an offset into the packet.
     add  33e5f0e   sizeof isn't useful when calculating the size of data in the packet.


Summary of changes:
 epan/dissectors/packet-lustre.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)