Wireshark-commits: [Wireshark-commits] master-2.4 ccc5b3e: Qt: Restore column visibility when loadi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Sep 2018 07:27:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ccc5b3e18a800740d8b64601fdac40cd8c6310e9
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

ccc5b3e by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Restore column visibility when loading packets
    
    Always restore column visibility when loading packets to avoid some
    situations where the column hidden state was incorrect.
    
    This fixes the following scenario:
     - Apply a column and hide it using the column popup menu
     - Apply another column and remove it using the column popup menu
     - Close and reopen the capture file
     - Observe the hidden column is shown, but with wrong width
    
    Change-Id: I00531907b2383c6605a2d62e8243092906037d0c
    Reviewed-on: https://code.wireshark.org/review/29516
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 7468107e1167d9526d6646a0870bf4c5a44ff91b)
    Reviewed-on: https://code.wireshark.org/review/29531
    (cherry picked from commit 2438a92d791c6be1fea53ed60a6024e8a124ff32)
    Reviewed-on: https://code.wireshark.org/review/29532
    

Actions performed:

    from  bcabcdc   The 2.4 version of licensecheck.pl doesn't support SPDX, so don't use it.
     add  ccc5b3e   Qt: Restore column visibility when loading packets


Summary of changes:
 ui/qt/packet_list.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)