Wireshark-commits: [Wireshark-commits] master 7d7175a: Qt: Restore column visibility when loading p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Sep 2018 07:26:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d7175a1308d914495bba5cde27e5bd2715d8644
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7d7175a by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Restore column visibility when loading packets
    
    Always restore column visibility when loading packets to avoid some
    situations where the column hidden state was incorrect.
    
    This fixes the following scenario:
     - Apply a column and hide it using the column popup menu
     - Apply another column and remove it using the column popup menu
     - Close and reopen the capture file
     - Observe the hidden column is shown, but with wrong width
    
    Change-Id: I00531907b2383c6605a2d62e8243092906037d0c
    Reviewed-on: https://code.wireshark.org/review/29516
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  7ce18dc   Clean up the references to ChUserTable.
     add  7d7175a   Qt: Restore column visibility when loading packets


Summary of changes:
 ui/qt/packet_list.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)