Wireshark-commits: [Wireshark-commits] master a93698a: Remove the tshark -z compare feature
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Sep 2018 23:55:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a93698a4ff1d2a403691a580dac5f26037047257
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a93698a by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Remove the tshark -z compare feature
    
      - It cannot support IPv6.
      - Non-standard use (specifically recommended against in the RFCs)
    of the IPv4 fragment ID field.
      - Has a narrow and non-obvious use case, IMO.
      - It is not supported in the Qt GUI.
      - Significant maintenance burden for an obscure feature.
    
    Change-Id: Icaf429269dc42f78c38b8d20001508132499faf8
    Reviewed-on: https://code.wireshark.org/review/29239
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  414e1c1   CMake: Use more descriptive name than WS_LD_FLAG_VALID0, 1, etc.
     add  a93698a   Remove the tshark -z compare feature


Summary of changes:
 CMakeLists.txt                                    |   1 -
 doc/tshark.pod                                    |   5 -
 docbook/release-notes.asciidoc                    |   1 +
 docbook/wsug_src/WSUG_chapter_statistics.asciidoc |  49 --
 ui/cli/.editorconfig                              |   4 -
 ui/cli/tap-comparestat.c                          | 603 ----------------------
 6 files changed, 1 insertion(+), 662 deletions(-)
 delete mode 100644 ui/cli/tap-comparestat.c