Wireshark-commits: [Wireshark-commits] master-2.2 d443be4: Fix handling of invalid type values.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Sep 2018 17:47:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d443be449a52f95df5754adc39e1f3472fec2f03
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.2
Repository: wireshark

Commits:

d443be4 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of invalid type values.
    
    If vType_get_type() returns NULL, that means that the packet is bad, not
    that the dissector is bad.  Report it as such.
    
    Bug: 15119
    Change-Id: I8e66fcece2b526ef9edbf948862f8fc5bea25d74
    Reviewed-on: https://code.wireshark.org/review/29511
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f4d2dffd8be1df30a832647a2f188507076f0fed)
    Reviewed-on: https://code.wireshark.org/review/29515
    

Actions performed:

    from  b378695   BT LE LL: fix invalid memory access reported by valgrind
     add  d443be4   Fix handling of invalid type values.


Summary of changes:
 epan/dissectors/packet-mswsp.c | 284 ++++++++++++++---------------------------
 1 file changed, 99 insertions(+), 185 deletions(-)