Wireshark-commits: [Wireshark-commits] master 152df20: docsis: validate header checksum before diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Sep 2018 07:19:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=152df201e5d84d759ddbce0c4cab541217561d70
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

152df20 by Andrii Vladyka (a.vladyka@xxxxxxx):

    docsis: validate header checksum before dissecting the payload
    
    When FCS validation is enabled in prortocol preferences, do not dissect PDUs with incorrect FCS.
    
    Change-Id: I6e09889cf5e4a5631930ee89b75de22c3b5f947e
    Reviewed-on: https://code.wireshark.org/review/29480
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  696f2ee   docsis: add CM STATUS-ACK MAC Management TLV (48)
     add  152df20   docsis: validate header checksum before dissecting the payload


Summary of changes:
 epan/dissectors/packet-docsis.c | 196 ++++++++++++++++++++++------------------
 1 file changed, 110 insertions(+), 86 deletions(-)