Wireshark-commits: [Wireshark-commits] master-2.2 b378695: BT LE LL: fix invalid memory access repo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 08 Sep 2018 20:05:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b37869599bc4faaa5e522b6fe4adbea5c3513fc6
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.2
Repository: wireshark

Commits:

b378695 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    BT LE LL: fix invalid memory access reported by valgrind
    
    - broadcast_addr shoudl be static and not on call stack
    - set the AT_STRINGZ address length with the string length and not the buffer length
    
    Bug: 13381
    Change-Id: I86e15ccaa9b5d7779c266ab24b637476e983664c
    Reviewed-on: https://code.wireshark.org/review/20103
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit fe78e1302f6076291e7270de2e8443ddb2c082af)
    Reviewed-on: https://code.wireshark.org/review/29496
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f783f47   Don't use on-the-stack buffers for pinfo addresses.
     add  b378695   BT LE LL: fix invalid memory access reported by valgrind


Summary of changes:
 epan/dissectors/packet-btle.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)