Wireshark-commits: [Wireshark-commits] master-2.2 1faaaa9: Migrate make-manuf to Python+CSV.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1faaaa9a0e6f1e1b59ddf7b41104607f713f26da
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.2
Repository: wireshark
Commits:
1faaaa9 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Migrate make-manuf to Python+CSV.
The download links offered by the IEEE at
https://standards.ieee.org/products-services/regauth/ are CSV files.
Updating the Perl version to support CSV would have required rewriting a
significant portion of the script along with either adding a dependency
on Text::CSV or writing our own CSV parser.
Migrate it to Python, which has a built-in CSV module.
Conflicts:
manuf
tools/make-manuf
Change-Id: I39ba0ec873145f44374ab9f751e8bde51535ca4d
Reviewed-on: https://code.wireshark.org/review/29442
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit a1fac65d8e9135014ff8cb9dfe9841e8b8267efb)
(cherry picked from commit 7c43ce01b3fcc6e5dd6bd89607a31496e0ce5fda)
Reviewed-on: https://code.wireshark.org/review/29469
Actions performed:
from 580575a PER: fix dissection of enumerated type with a single extension value
add 1faaaa9 Migrate make-manuf to Python+CSV.
Summary of changes:
manuf | 1184 +++++++++++++++++++++++++++++----------------------
manuf.tmpl | 10 +-
tools/make-manuf | 284 ------------
tools/make-manuf.py | 224 ++++++++++
4 files changed, 906 insertions(+), 796 deletions(-)
delete mode 100755 tools/make-manuf
create mode 100755 tools/make-manuf.py