Wireshark-commits: [Wireshark-commits] master-2.6 9d61d41: Migrate make-manuf to Python+CSV.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Sep 2018 16:01:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d61d410c63f9c5b02eca92c5857181da2bf0e0d
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

9d61d41 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Migrate make-manuf to Python+CSV.
    
    The download links offered by the IEEE at
    https://standards.ieee.org/products-services/regauth/ are CSV files.
    Updating the Perl version to support CSV would have required rewriting a
    significant portion of the script along with either adding a dependency
    on Text::CSV or writing our own CSV parser.
    
    Migrate it to Python, which has a built-in CSV module.
    
    Change-Id: I39ba0ec873145f44374ab9f751e8bde51535ca4d
    Reviewed-on: https://code.wireshark.org/review/29442
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit a1fac65d8e9135014ff8cb9dfe9841e8b8267efb)
    Reviewed-on: https://code.wireshark.org/review/29467
    

Actions performed:

    from  b407f7a   wslua: fix source argument in debug info for luacov
     add  9d61d41   Migrate make-manuf to Python+CSV.


Summary of changes:
 manuf               | 2577 +++++++++++++++++++++++++++------------------------
 manuf.tmpl          |   10 +-
 tools/make-manuf    |  306 ------
 tools/make-manuf.py |  210 +++++
 4 files changed, 1569 insertions(+), 1534 deletions(-)
 delete mode 100755 tools/make-manuf
 create mode 100755 tools/make-manuf.py