Wireshark-commits: [Wireshark-commits] master 7b37c5c: Qt: Add null check for finfo and hfinfo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Sep 2018 08:34:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b37c5c180eff710c49ee324869c9ad4dc5c7262
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7b37c5c by Martin Boye Petersen (martinboyepetersen@xxxxxxxxx):

    Qt: Add null check for finfo and hfinfo
    
    Adding the null check fixes a bug that made wireshark crash
    when right clicking a subtree which doesn't have any preferences
    and if none of the parents had one either.
    
    The problem was introduced in commit 589413d8772f1450be9bd4a2550cb99a95f71299
    
    Change-Id: Ia5bbae0a58298f3e9d912e44f33589da1cbfacc9
    Reviewed-on: https://code.wireshark.org/review/29455
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  04ef87a   We build Wireshark with Qt 5.9.5 on Windows; update the developer's guide.
     add  7b37c5c   Qt: Add null check for finfo and hfinfo


Summary of changes:
 ui/qt/proto_tree.cpp              | 3 ++-
 ui/qt/utils/field_information.cpp | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)