Wireshark-commits: [Wireshark-commits] master-2.4 94d5b91: Radius: Fix offset for multiple VSA in o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 06 Sep 2018 05:10:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94d5b9134ed695563a7dc75c9f6830018659d43f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

94d5b91 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    Radius: Fix offset for multiple VSA in one AVP
    
    When there are multiple VSAs in one AVP we should forward the vendor_offset.
    The length field includes the type field therefore we have to subtract it.
    
    Bug: 15073
    Change-Id: If365ebca493208d67b3283fe876d2d1b0bda64af
    Reviewed-on: https://code.wireshark.org/review/29421
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 6e36e3757a499c2347db4cb1633cc2824577bc87)
    Reviewed-on: https://code.wireshark.org/review/29424
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ef5215e   tvbuff_subset.c: handle a reported_length set to -1 in tvb_new_subset_length()
     add  94d5b91   Radius: Fix offset for multiple VSA in one AVP


Summary of changes:
 epan/dissectors/packet-radius.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)