Wireshark-commits: [Wireshark-commits] master-2.4 ef5215e: tvbuff_subset.c: handle a reported_lengt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 05 Sep 2018 20:44:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef5215e779b5aa83d527767588f9a555bda51a52
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

ef5215e by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    tvbuff_subset.c: handle a reported_length set to -1 in tvb_new_subset_length()
    
    According to tvbuff.h, tvb_new_subset_length() should behave like
    tvb_new_subet_caplen(). Let's do so.
    
    Bug: 15112
    Change-Id: I3f05ff45246ac0d05e9bc7bd069ec864da1afae6
    Reviewed-on: https://code.wireshark.org/review/29426
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit b40beb9edfc5c09bb2374e2382871a7fc8825858)
    Conflicts:
    	epan/tvbuff_subset.c
    Reviewed-on: https://code.wireshark.org/review/29439
    (cherry picked from commit b394744c26ff450a5bf44dee94de3a04f8f46fff)
    Reviewed-on: https://code.wireshark.org/review/29440
    

Actions performed:

    from  54cf04c   prefs: Improve check for visible custom columns
     add  ef5215e   tvbuff_subset.c: handle a reported_length set to -1 in tvb_new_subset_length()


Summary of changes:
 epan/tvbuff_subset.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)