Wireshark-commits: [Wireshark-commits] master 65b342f: epan: Use g_base64_decode_inplace()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 03 Sep 2018 04:05:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65b342f7497825c2abc4e98c7fd9f4ff6d8ed45c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

65b342f by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Use g_base64_decode_inplace()
    
    Replace ws_base64_decode_inplace() with g_base64_decode_inplace()
    or g_base64_decode(), which was introduced in glib 2.12.
    
    The only observed difference is a need for zero-terminate the buffer
    after decoding.
    
    Change-Id: Ia102d0d8e9bec575ffeddf448191a3f6de9fb1ed
    Reviewed-on: https://code.wireshark.org/review/29382
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  42ad608   ISIS (LSP/HELLO): Add RFC 6119 (IPv6 Traffic Engineering in IS-IS)
     add  65b342f   epan: Use g_base64_decode_inplace()


Summary of changes:
 debian/libwsutil0.symbols          |  1 -
 epan/dissectors/packet-http.c      | 18 +++++++----
 epan/dissectors/packet-smtp.c      | 39 +++++++++++++++-------
 epan/tvbuff_base64.c               |  9 +++---
 epan/wslua/wslua_byte_array.c      | 11 +++----
 ui/qt/show_packet_bytes_dialog.cpp |  6 ++--
 wsutil/CMakeLists.txt              |  2 --
 wsutil/base64.c                    | 66 --------------------------------------
 wsutil/base64.h                    | 27 ----------------
 9 files changed, 51 insertions(+), 128 deletions(-)
 delete mode 100644 wsutil/base64.c
 delete mode 100644 wsutil/base64.h