Wireshark · Wireshark-commits: [Wireshark-commits] master bb25d64: IP: Use pinfo for session IP addresses

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb25d64a2a240dcfd6469d5e389a996f7a4637d7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bb25d64 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    IP: Use pinfo for session IP addresses
    
    The pinfo structure is sufficent for providing the src/dst address.
    The pinfo address data is strictly the same as the tap data, even for
    IP over IP.
    
    Besides the trivial code simplification we prioritize the use of pinfo
    over a tap, for increased type-safety and on the presumption of having
    a more stable implementation (in the mutability sense).
    
    Change-Id: Idcfc8c762f9af934e4612522b7472b35a01042ca
    Reviewed-on: https://code.wireshark.org/review/29238
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ca355b8   WSDG: Miscellaneous fixups.
     add  bb25d64   IP: Use pinfo for session IP addresses


Summary of changes:
 epan/dissectors/packet-ip.c   | 12 +++++-------
 epan/dissectors/packet-ipv6.c | 12 +++++-------
 2 files changed, 10 insertions(+), 14 deletions(-)