Wireshark-commits: [Wireshark-commits] master f7d4b2c: kerberos: Fix several memory leaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Aug 2018 06:44:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7d4b2ca350629a2e207e238376bfffd1214c25f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f7d4b2c by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    kerberos: Fix several memory leaks
    
    valgrind --tool=memcheck --leak-check=full ./run/tshark \
        -r ../test/captures/krb-816.pcap.gz \
        -o "kerberos.decrypt:TRUE" \
        -o "kerberos.file:../test/keys/krb-816.keytab" \
        -Tfields -e kerberos.keyvalue
    
    24 bytes in 2 blocks are definitely lost in loss record 37 of 117
       at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
       by 0xCB9FE1F: krb5_ktfileint_internal_read_entry.isra.5 (kt_file.c:1359)
       by 0xCBA1436: krb5_ktfileint_read_entry (kt_file.c:1409)
       by 0xCBA1436: krb5_ktfile_get_next (kt_file.c:510)
       by 0x7A55A4F: read_keytab_file (packet-kerberos-template.c:324)
       by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249)
       by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383)
    
    141 (80 direct, 61 indirect) bytes in 2 blocks are definitely lost in loss record 99 of 117
       at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
       by 0xCB9F9D9: krb5_ktfileint_internal_read_entry.isra.5 (kt_file.c:1237)
       by 0xCBA1436: krb5_ktfileint_read_entry (kt_file.c:1409)
       by 0xCBA1436: krb5_ktfile_get_next (kt_file.c:510)
       by 0x7A55A4F: read_keytab_file (packet-kerberos-template.c:324)
       by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249)
       by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383)
    
    8,343 (24 direct, 8,319 indirect) bytes in 1 blocks are definitely lost in loss record 116 of 117
       at 0x4C30B06: calloc (vg_replace_malloc.c:711)
       by 0xCB9F129: krb5_ktfile_resolve (kt_file.c:198)
       by 0xCB9DE82: krb5_kt_resolve (ktbase.c:175)
       by 0x7A559BC: read_keytab_file (packet-kerberos-template.c:310)
       by 0x7A55922: read_keytab_file_from_preferences (packet-kerberos-template.c:249)
       by 0x7A55EC4: decrypt_krb5_data (packet-kerberos-template.c:383)
    
    Change-Id: Ia6f62d8576f3812e8832acc747eac84de8383756
    Reviewed-on: https://code.wireshark.org/review/29146
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3bb4ee5   Docs: AUTHORS formatting updates.
     add  f7d4b2c   kerberos: Fix several memory leaks


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 22 +++++++++++++++--
 epan/dissectors/packet-kerberos.c                  | 28 ++++++++++++++++++----
 2 files changed, 43 insertions(+), 7 deletions(-)